Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignable Sounds to Countdown (per-stage) #15439

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

crowplexus
Copy link
Contributor

@crowplexus crowplexus commented Aug 29, 2024

these changes allow for custom intro sounds based on stage files
also adds an additional image when the narrator says "3" during the countdown, which can be toggled by adding an image called prepare into the images folder in any mod (meaning it isn't enabled by default)


supersedes #15434 and fixes #14474

  • Supersedes the aforementioned PR as you can simply put an empty string, null, or an empty array in the intro sounds array, making it way more customisable

@LarryFrosty
Copy link
Contributor

rip goofy null trace

Copy link

@TheOfficialSwords TheOfficialSwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is Fire.

@PartnerCapPikachu
Copy link
Contributor

ily

@DMMaster636
Copy link
Contributor

really nice! def makes some stuff easier
i have a few more ideas for improvements if this does get merged

@crowplexus
Copy link
Contributor Author

crowplexus commented Sep 16, 2024

I might make a countdown class to make this process less cluttered
spoiler: I didn't

@crowplexus crowplexus changed the title Improve Countdown Modifications Assignable Sounds to Countdown (per-stage) Oct 12, 2024
@crowplexus crowplexus changed the base branch from experimental to main October 15, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants