Merge pull request #936 from Shared-Reality-Lab/moving-healthchecks

Deploying Preprocessor Healthchecks
Shared-Reality-Lab · Dec 20, 2024 · 114140f · 114140f
2 parents 31090fd + c11e325
commit 114140f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 23 deletions.
diff --git a/preprocessors/grouping/Dockerfile b/preprocessors/grouping/Dockerfile
@@ -17,4 +17,7 @@ EXPOSE 5000
 
 ENV FLASK_APP=grouping.py
 USER python
+
+HEALTHCHECK --interval=60s --timeout=10s --start-period=120s --retries=5 CMD curl -f http://localhost:5000/health || exit 1
+
 CMD [ "gunicorn", "grouping:app", "-b", "0.0.0.0:5000", "--capture-output", "--log-level=debug" ]
diff --git a/preprocessors/mmsemseg/Dockerfile b/preprocessors/mmsemseg/Dockerfile
@@ -50,4 +50,7 @@ RUN wget https://image.a11y.mcgill.ca/resources/models/mmsemseg/upernet_beit-bas
 EXPOSE 5000
 ENV FLASK_APP=segment.py
 USER python
+
+HEALTHCHECK --interval=60s --timeout=10s --start-period=120s --retries=5 CMD curl -f http://localhost:5000/health || exit 1
+
 CMD [ "gunicorn", "segment:app", "-b", "0.0.0.0:5000", "--capture-output", "--log-level=debug" ]
diff --git a/preprocessors/ocr/Dockerfile b/preprocessors/ocr/Dockerfile
@@ -16,4 +16,7 @@ EXPOSE 5000
 
 ENV FLASK_APP=ocr.py
 USER python
+
+HEALTHCHECK --interval=60s --timeout=10s --start-period=120s --retries=5 CMD curl -f http://localhost:5000/health || exit 1
+
 CMD [ "gunicorn", "ocr:app", "-b", "0.0.0.0:5000", "--capture-output", "--log-level=debug" ]
diff --git a/test-docker-compose.yml b/test-docker-compose.yml
@@ -36,12 +36,6 @@ services:
 
 # override gpu selection on test environment
   semantic-segmentation:
-    healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:5000/health"]
-      interval: 60s
-      timeout: 10s
-      retries: 5
-      start_period: 120s
     deploy:
       resources:
         reservations:
@@ -120,20 +114,4 @@ services:
       - "traefik.http.routers.tat.tls.certresolver=myresolver"
       - traefik.docker.network=traefik
     environment:
-      - SERVER_NAME=unicorn.cim.mcgill.ca
-
-  object-grouping:
-    healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:5000/health"]
-      interval: 60s
-      timeout: 10s
-      retries: 5
-      start_period: 120s
-
-  ocr-clouds-preprocessor:
-    healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:5000/health"]
-      interval: 60s
-      timeout: 10s
-      retries: 5
-      start_period: 120s
+      - SERVER_NAME=unicorn.cim.mcgill.ca