fix: pickle and deep copy classification models with EP #1108
+38
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Longer description:
EPBase
class since it does not have parent classes (raises an error otherwise - I suspect methods employing this command were never used or tested).__setstate__
and__getstate__
methods as they did not fully capture the state of an instance, making the implementation brittle. An error would be raised when pickling and unpickling an instance (for example, theself.always_reset
attribute was missing). By removing these instances, Python now defaults to using the__dict__
method of the class, which works well and is much simpler.