Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-assembly to 2.1.4 #313

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates com.eed3si9n:sbt-assembly from 1.1.0 to 2.1.4 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (1.1.0).
You might want to review and update them manually.

src/test/scala/io/shiftleft/js2cpg/passes/DependenciesPassTest.scala
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-assembly" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.eed3si9n", artifactId = "sbt-assembly" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

@max-leuthaeuser
Copy link
Contributor

max-leuthaeuser commented Nov 7, 2023

@mpollmeier Do you think this is safe to to? (this is a huge version bump)
The -internal build is also already at the 2.x version.

@mpollmeier
Copy link
Contributor

Looks to me like this build doesn't use sbt-assembly at all, so my suggestion would be to either drop it, or if you want to use it: configure it (with a similar configuration as the -internal build, specifically the assemblyMergeStrategy setting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants