Skip to content
This repository has been archived by the owner on May 1, 2021. It is now read-only.

Update package path in docs #10

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Update package path in docs #10

merged 1 commit into from
Dec 19, 2019

Conversation

dwightjack
Copy link
Contributor

I updated the docs with the correct inclusion path (See ShiftbrainStd/polyrhythm-typography#9).

It looks like the namespace is not used when using the $module parameter in functions like meta.get-function:

@use "sass:meta";
@use "@shiftbrainstd/harmonic-modular-scale";

// works
meta.get-function("get-sizes", $module: "harmonic-modular-scale")

// doesn't work
meta.get-function("get-sizes", $module: "@shiftbrainstd/harmonic-modular-scale")

@dwightjack
Copy link
Contributor Author

@yuheiy please review

@dwightjack dwightjack marked this pull request as ready for review December 18, 2019 09:30
@dwightjack dwightjack requested a review from yuheiy December 18, 2019 09:30
Copy link
Member

@yuheiy yuheiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuheiy yuheiy merged commit 7aedd7c into master Dec 19, 2019
@yuheiy yuheiy deleted the readme-update branch December 19, 2019 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants