Skip to content

Commit

Permalink
ws-76(fix): fix double running of mounting useEffect
Browse files Browse the repository at this point in the history
  • Loading branch information
ShiiRochi committed Feb 17, 2024
1 parent a0ebf3e commit f45a0cb
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/hooks/useWavesurfer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ function createPluginsMap<GPlug extends GenericPlugin>(curr: PluginDictionary<GP

export default function useWavesurfer<GPlug extends GenericPlugin>({ container, plugins = [], onMount, ...props }: UseWaveSurferParams<GPlug>) {
const isInitilizing$ = useRef<boolean>(false);

const [pluginsMap, setPluginsMap] = useState<PluginDictionary<GPlug>>({});
// is used to keep track of initialized plugins
const initialized$ = useRef<string[]>([]);
Expand All @@ -45,10 +46,14 @@ export default function useWavesurfer<GPlug extends GenericPlugin>({ container,
useEffect(() => {
if (!container) return;

if (isInitilizing$.current) return;
// keep track of container
const prevContainer = container;

// do not allot to create WaveSurfer instance twice
if (isInitilizing$.current) return;
isInitilizing$.current = true;


const _plugins = createPluginsMap(pluginsMap, plugins);

initialized$.current = Object.keys(_plugins);
Expand All @@ -65,6 +70,9 @@ export default function useWavesurfer<GPlug extends GenericPlugin>({ container,
setWavesurfer(ws);

return () => {
// if container did not changed, but useEffect is still called,
// prevent destroy if container or all-others hook dependencies are not changed
if (prevContainer === container) return;
ws.destroy();
};
}, [container]);
Expand Down

0 comments on commit f45a0cb

Please sign in to comment.