-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UEX Corp data runner skill #240
base: main
Are you sure you want to change the base?
Conversation
Neat idea! I don't play star citizen so cannot comment on the substance. I did not even know wingman had a "get skill" function so I need to look into that, very creative. We haven't historically had skills that have relied on other skills but I can see the attractiveness of not having to duplicate a bunch of code that is already there in other skills. At minimum, though, I think during validate there would need to be a check for what happens if the skills it depends on are not there. Have to think about this more. Looking forward to hearing others' thoughts. EDIT: Ok, subject to further confirmation from Simon/Timo, looking at the code I'm pretty sure there's not actually a get_skill() method in either wingman or openaiwingman, which means this approach would not presently work. But it seems like a good concept worthy of further exploration. |
There is a self.wingman.skills property / variable though which should be a list, so you might be able to check if skillname in self.wingman.skills |
…I prompt to a separate method.
Thanks for the feedback @teddybear082. I've made some revisions.
|
I'm working on an update to the StarHead Skill and wanted to implement something similar as StarHead has also an API to update commodity prices. Maybe we can create one "data runner" skill and custom options to set it to UEXCorp or StarHead (or other APIs in the future)?! What do you think? |
I think we should keep them separate as different API's may require different logic and structure. Therefore it might result in many if else statements making the code less readable and harder to maintain. BTW @danielduckworth - if you need any additions to the uex skill, let me know! (On Discord its JayMatthew) |
Ok, then it's a dogfight! |
Maybe it's also best to create a Discord Thread for this?! Makes it easier to communicate. I like the idea of relaying on other skills but right now there is no "analyse_image" function in the vision skill. I would refactor it to easily use the functions, maybe also for making the screenshot etc. So you don't need a dependency to the screenshot skill as well. |
Good idea @TimoKorinth with the Discord thread. @SawPsyder I sent a request on Discord (as dux). In terms of additions to the uexcorp skill, what would be great is a fuzzy search function (or semantic search using embeddings) to match queries (e.g. "Loreville admin terminal") with terminal IDs. Ideally this would be available as a REST API from UEX Corp rather than as a middleware function. |
…erified_data_to_uexcorp tools
…d submit_verified_data_to_uexcorp tools
@TimoKorinth or @SawPsyder would you mind reviewing this PR as I cannot test it? Thank you! |
@danielduckworth the skill definitely needs an icon in 128x128px (png). How should we credit you as author on https://www.wingman-ai.com/skills ? |
…erifying trading terminal data, and submitting verified data to UEXCorp. Use fuzzy search.
Hi, I'm working on an additional skill based on vision_ai and uexcorp that captures commodity price data from screenshots and submits them to the /data_submit endpoint.
This is a first pass and not yet tested. I'm just looking for some feedback about the overall structure, flow, and anything I might need to import to start testing it.