Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify carrier abbv creation #233

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamesfneyer
Copy link
Contributor

Change the flow of the quickadd shipment, so that the quickadd_tracking field is checked in the signal.
The carrier_abbv field is then modified based on the response from the detect/courier request.

@jamesfneyer
Copy link
Contributor Author

@ajhodges I moved the quickadd tracking validate from the serializer to the signal, since the goal is to use that instead of the aftership create to retrieve the name of the carrier, and I wanted to limit the number of calls. The other option was to add it in the validate function of the serializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant