[BFCL] Fix UNDERSCORE_TO_DOT for Locally-Hosted Models #854
+90
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question before merging this. Why not convert dot to underscore for all models? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For locally hosted models, when doing inference, the
.in the function name is replaced with_(code section here). As a result, these models must be added to the UNDERSCORE_TO_DOT list so that their function names are correctly matched during evaluation. Previously, not all locally hosted models were included in that list. This PR fixed this issue by having theUNDERSCORE_TO_DOTlist contain all models in thelocal_inference_handler_map.