fix sorting of the manually linked files #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by episode type, episode number, followed by file creation date. If the manually linked components were refactored to use the episode endpoint first and foremost then we might have avoided to do this client-side sorting. But. I'm not going to put in the effort to refactor them all at this point in time, so this band-aid will do for now. At least until somebody puts in the time and effort to do the work.
|
The UI for this page and will change to the dual pane one like release management and then the episode list will be paginated, and then we cannot sort it. What we need to do is to get the episodes instead of files. Is that possible? 🤔 |
|
Not needed due to #1067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sorting of the manually linked files by episode type, episode number, followed by file creation date.
If the manually linked components were refactored to use the episode endpoint first and foremost then we might have avoided to do this client-side sorting. But. I'm not going to put in the effort to refactor them all at this point in time, so this band-aid will do for now. At least until somebody puts in the time and effort to do the work.