Add api_version to access.admin in app.toml
#4360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
billfienberg
changed the title
api_version to access.admin in app.toml
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/system.d.ts@@ -1,5 +1,8 @@
/// <reference types="node" resolution-mode="require"/>
+/// <reference types="node" resolution-mode="require"/>
+/// <reference types="node" resolution-mode="require"/>
import { AbortSignal } from './abort.js';
+import { ReadStream } from 'tty';
import type { Writable, Readable } from 'stream';
export interface ExecOptions {
cwd?: string;
@@ -45,8 +48,11 @@ export declare function exec(command: string, args: string[], options?: ExecOpti
*/
export declare function sleep(seconds: number): Promise<void>;
/**
- * Check if the standard input and output streams support prompting.
+ * In case an standard input stream is passed check if it supports raw mode. Otherwise default standard input stream
+ * will be used.
*
- * @returns True if the standard input and output streams support prompting.
+ * @param stdin - The standard input stream to check.
+ * @param env - Environmemnt variables.
+ * @returns True in the selected input stream support raw mode.
*/
-export declare function terminalSupportsPrompting(): boolean;
\ No newline at end of file
+export declare function terminalSupportsRawMode(stdin?: ReadStream, env?: NodeJS.ProcessEnv): boolean;
\ No newline at end of file
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1859 tests passing in 846 suites. Report generated by 🧪jest coverage report action from 90177b6 |
🎩 TophatBefore (
|
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
TLDR: Add api_version to access.admin in app.toml #4360
Part of https://github.com/Shopify/app-ui/issues/1474
WHAT is this pull request doing?
api_version: zod.string().optional()toAppAccessSchemaHow to test your changes?
api_versioninsideaccess.admincli, checkout thebf/add-api-version-to-app-tomlbranchcli,deployyour updated app toml file using the--pathargpnpm shopify app deploy --path ~/src/github.com/Shopify/hackdays-appconfig:linkto pull your config from the DBapi_versionis presentPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
References