Add null check for summary.NextElementSibling
in global.js
#3453
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR adds a check in
global.js
that prevents trying to access a<summary>
element sibling if it doesn't exist.Why are these changes introduced?
Fixes #3452
What approach did you take?
Use optional chaining on the
nextElementSibling
query.Visual impact on existing themes
Merchants that have a
<summary>
element that matches the defaultglobal.js
selector but don't have a sibling won't cause the page's javascript to thrown an exception.Testing steps/scenarios
Customizing the theme's product page by adding an html snippet like the one below shouldn't break option/variant selection:
Checklist