Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=fix the issue #3524 #3543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Made4Uo
Copy link

@Made4Uo Made4Uo commented Jun 29, 2024

PR Summary:

This resolve issue #3524, Clicking the image on the product page magnifies it significantly. The image does not provide good user experienced when it was zoomed so much.

I adjusted the product modal images to fit the screen and be able to view images without being cut off

Why are these changes introduced?

Fixes #3524.
I changed mostly the coide in the section-main-product.css

What approach did you take?

I made sure that the images are responsive to devices.

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

This will show the product modal images without cutting off

Testing steps/scenarios

  • Step 1 - Test the responsiveness in screen above 750px
  • Step 2 - Test the responsive in screen below 749px
  • Step 3 - Test view on portrait photos, landscape, and square images for all screens

Demo links

https://xnnmrs5twhqwt5v2-57889030244.shopifypreview.com/products/dark-denim-top
https://theme-bella1.myshopify.com/?preview_theme_id=136173748324/products/dark-denim-top

Checklist

.product-media-modal__content .global-media-settings {
width: auto;
height: 90vh; /* Show preview of next image to let user know that this can be scrolled */
aspect-ratio: 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspect-ratio-example
Shirt on left: aspect-ratio: 1;
Shirt on right: aspect-ratio: auto;

aspect-ratio: 1; is causing some images to become distorted when testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the image on the product page magnifies it significantly.
2 participants