Fix removing multiple event listeners of the same type #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes...
Emitter#off
fails to remove multiple event listeners of the same type. This PR also adds "removes multiple callbacks of event type
" test case which demonstrates this issue.The
Array.filter()
approach is slightly faster as well (at least on Chrome, but probably across the board):Does this PR require the Docs to be updated?
No
Does this PR require new tests?
No