Rename sharding.Config.SourceDB => SourceSchema #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SourceDB` and `TargetDB` on `sharding.Config` refers to the schema name of a database. `SourceDB` is also used on `ghostferry.Ferry` to point to a `*sql.DB`. Since the `Ferry` struct also embeds a `Config` struct (a q uestionable choice to begin with), this naming caused me significant confusion. I'm not sure if this adds to more confusion, but I want to quickly raise this issue as this is not the first time I got confused by variable names using words such as: "schema", "db"/"database", "table", and "table schema".
hkdsun
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceDBandTargetDBonsharding.Configrefers to the schema name of a database.SourceDBis also used onghostferry.Ferryto point to a*sql.DB. Since theFerrystruct also embeds aConfigstruct (a questionable choice to begin with), this naming caused me significant confusion.I'm not sure if this adds to more confusion, but I want to quickly raise this issue as this is not the first time I got confused by variable names using words such as: "schema", "db"/"database", "table", and "table schema".