Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Update qless-core to latest version #9

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Conversation

bslobodin
Copy link

@bslobodin bslobodin commented Sep 6, 2017

We have run into issues with latest Redis in dev up, this PR updates the qless-core lua scripts as per seomoz/qless-core#64.

git submodule init
git submodule update --remote --merge
make qless.lua
make qless-lib.lua

@bslobodin bslobodin self-assigned this Sep 6, 2017
@bslobodin bslobodin changed the title Update qless-core to latest 🚧 Update qless-core to latest version Sep 6, 2017
@melari
Copy link

melari commented Sep 6, 2017

👍

Copy link

@cyprusad cyprusad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to top hat unfortunately

@bslobodin bslobodin merged commit 3976fbf into master Sep 6, 2017
@bslobodin bslobodin deleted the update-qless-core branch September 6, 2017 14:48
Copy link

@girasquid girasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - reading all of these or falses makes me think that there's an argument to be made for a helper method here, but this works

@bslobodin
Copy link
Author

@girasquid perhaps, though we never modified qless-core with our fork, this was simply bringing the current version of that submodule into our outer fork...

@girasquid
Copy link

Yeah - that works!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants