Implement translation for break node
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Aug 27, 2024
|
|
||
| # with arguments | ||
| while true | ||
| break foo |
There was a problem hiding this comment.
I did not know that break took arguments 😅
There was a problem hiding this comment.
I've seen lots of reasons to use next with values (e.g. "early return" from a block passed to Promise#then, but not actually return out of the surrounding def method), but never break, haha
amomchilov
reviewed
Aug 27, 2024
|
|
||
| # with arguments | ||
| while true | ||
| break foo |
There was a problem hiding this comment.
I've seen lots of reasons to use next with values (e.g. "early return" from a block passed to Promise#then, but not actually return out of the surrounding def method), but never break, haha
amomchilov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
Test plan
See included automated tests.