Implement Prism -> Sorbet translation for anonymous Array and Hash splats #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
Alex/translate-call-kwrest
branch
from
262ceca
to
7d5cc91
Compare
amomchilov
changed the base branch from
prism
to
Alex/translate-anonymous-params
amomchilov
changed the title
amomchilov
force-pushed
the
Alex/translate-anonymous-params
branch
from
bd06e33
to
09e8803
Compare
It was still a copy of `def_kw_rest_params`, and were still testing method defs, not calls.
amomchilov
force-pushed
the
Alex/translate-call-kwrest
branch
from
7d5cc91
to
84cdc53
Compare
amomchilov
commented
Sep 12, 2024
Comment on lines
+129
to
+130
| unreachable("PM_ASSOC_SPLAT_NODE is handled separately in `Translator::translateHash()`, because its " | ||
| "translation depends on whether its used in a hash or in a method call"); |
There was a problem hiding this comment.
This prevents us from needing to maintain a parsing context, that remembers whether this recursive call to Translator::translate() originated from a PM_HASH_NODE or a PM_KEYWORD_HASH_NODE.
amomchilov
force-pushed
the
Alex/translate-call-kwrest
branch
from
84cdc53
to
c59eaea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Builds on top of #42 and #225 to add support for anonymous splats.
Test plan
See included automated tests.