[Exploration] Translate Prism nodes directly into AST::Expression nodes
#238
Commits on Sep 4, 2024
-
-
Instead of listing all the `srcs` and `hdrs` for the Prism C library, use a glob to pull all `.c` and `.h` files, excluding the ones that are generated by the genrule so that we can specify that the library depends on that genrule without listing those files twice.
-
Add
--parseroption and use it to decide whether to parse with Sorb……et or prism If `--parser=prism`, diverge in the `pipeline.cc` file and run a separate method that parses the source with prism.
-
Implement parsing a program with just an integer
This involves setting up a `convertPrismToSorbet` method that checks against every possible node type. Program and Statements are basically skipped because Sorbet doesn't use them, and then Integer is converted from a prism node to a Sorbet node. Co-authored-by: Vinicius Stock <[email protected]>
-
-
-
-
-
1. Add a new test suite that only tests files in the `test/prism_regression` folder 2. Modify Sorbet's test code to allow the user to specify a parser 3. Add logic to the pipeline test runner to call `runPrismParser` when specified
-
-
-
-
Implement prism -> sorbet conversion for multi-statement programs
Sorbet constructs slightly different ASTs depending on whether a program contains one statement or more than one statements. Correctly parsing programs with more than one statement will make it easier to benchmark this project.
-
Modify
runPrismParsermethod to respectstopAfteroptionIn order to compare the performance of Prism with the Sorbet parser, we need to be able to stop AST generation after Prism has run and before we translate the Prism AST into the Sorbet AST.
-
These benchmarks will help us measure the progress of the prism in Sorbet project. While they can be run from any machine, for "official" results, they should be run on an AWS bare metal instance. Results should be added to the prism_benchmarks/data directory.
-
-
-
Refactor statements node handling
Relocate it to the `PM_STATEMENTS_NODE` case so it can be reused by multiple parent nodes.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Now that it’s own by the `Prism::Translator` class, it’s association to Prism is implied, and doesn’t need to be spelled out in its name.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Prism now represents rationals as numerator/denominator, which doesn't preserve the original representation of the numerical value. We just pull the value as a string from source and pass it to Sorbet. Co-authored-by: Alex Momchilov <[email protected]>
-
-
-
-
-
Create
extractStringmethod in Prism parserTo pull out the process of taking a `pm_string_t` and using it to extract a string from the source code.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Create template to generalize assignment translations
The template takes the Prism and Sorbet node types, as well as Sorbet's LHS node type. Then, it performs the assignment translation correctly given all of those types.
-
-
Commits on Sep 6, 2024
-
Merge pull request #234 from Shopify/emily/index-assign
Implement Prism -> Sorbet translation for index assign nodes
-
-
-
Commits on Sep 7, 2024
-
Merge pull request #235 from Shopify/Alex/translate-anonymous-params
Implement missed translations for anonymous `*`, `**` and `&` params
Commits on Sep 9, 2024
-
Create a template abstracting variable assignment logic
And use the template on all nodes where we create an `Assign` Sorbet node.
Commits on Sep 12, 2024
-
Merge pull request #236 from Shopify/emily/const-write
Implement Prism -> Sorbet translation for `PM_CONSTANT_WRITE_NODE`
-
-
Merge pull request #237 from Shopify/emily/const-path-write
Implement translation for `PM_CONSTANT_PATH_WRITE_NODE`
-
Fix
call_kw_restto actually test method callsIt was still a copy of `def_kw_rest_params`, and were still testing method defs, not calls.
-
Commits on Sep 13, 2024
-
-
-
-
-
-
Merge pull request #232 from Shopify/Alex/translate-call-kwrest
Implement Prism -> Sorbet translation for anonymous Array and Hash splats
Commits on Sep 16, 2024
-
Merge pull request #228 from Shopify/Alex/translate-keyword-it
Implement Prism -> Sorbet translation for `it` keyword
-