Require actual version of sorbet-static-and-runtime as minimum
#1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `sorbet-static` and `sorbet-runtime` versions `0.5.9204` do exist, `0.5.9519` is the first version of `sorbet-static-and-runtime` published on RubyGems, so we cannot depend on anything lesser than that.
|
If we can bump the minimum version to |
paracycle
approved these changes
Nov 4, 2022
This feature is supported from Sorbet versions 0.5.9220 onwards, and since we require at least 0.5.9519, we know it is supported.
|
@paracycle, I've added commits getting rid of a feature flag by successively bumping the version, and added a documentation comment to the now empty hash (as I imagine we want to keep it around for future use). Alternatively, I could delete all the feature checking code, if that's not something we want to keep around. |
By bumping the minimum Sorbet version, we can avoid the feature check.
By bumping the minimum Sorbet version, we can avoid the feature check.
Rather than remove the feature check code, we document it for future use.
sambostock
force-pushed
the
bump-sorbet-static-and-runtime-requirement
branch
from
029a352 to
f0aadd0
Compare
vinistock
approved these changes
Nov 7, 2022
|
I don't know about the generics syntax specifically, but trying out this branch on Core passes RBI related CI checks. It's already on Sorbet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While
sorbet-staticandsorbet-runtimeversions0.5.9204do exist,0.5.9519is the first version ofsorbet-static-and-runtimepublished on RubyGems, so we cannot depend on anything lesser than that.We can potentially require an even newer version, as discussed in #1252 (comment), but I'm not sure which, so I've not made that change yet.As per @paracycle's comment, I've gone ahead and further bumped the minimum version requirement to a version that allows us to get rid of our feature checks.
Implementation
This updates the version in
tapioca.gemspecand refreshesGemfile.lockaccordingly.Tests
All existing tests apply.