consensus: Ban empty v2 transactions

SiaFoundation · Oct 28, 2024 · 1fcd548 · 1fcd548
1 parent bbe823b
commit 1fcd548
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/consensus/state.go b/consensus/state.go
@@ -341,7 +341,8 @@ func (s State) V2TransactionWeight(txn types.V2Transaction) uint64 {
 	for _, a := range txn.Attestations {
 		a.EncodeTo(e)
 	}
-	e.WriteBytes(txn.ArbitraryData)
+	e.Write(txn.ArbitraryData)
+	e.Flush()
 	return uint64(wc.n)
 }
 

diff --git a/consensus/validation.go b/consensus/validation.go
@@ -888,7 +888,9 @@ func ValidateV2Transaction(ms *MidState, txn types.V2Transaction) error {
 		return errors.New("v2 transactions are not allowed until v2 hardfork begins")
 	} else if err := validateV2CurrencyOverflow(ms, txn); err != nil {
 		return err
-	} else if weight := ms.base.V2TransactionWeight(txn); weight > ms.base.MaxBlockWeight() {
+	} else if weight := ms.base.V2TransactionWeight(txn); weight == 0 {
+		return errors.New("transactions cannot be empty")
+	} else if weight > ms.base.MaxBlockWeight() {
 		return fmt.Errorf("transaction exceeds maximum block weight (%v > %v)", weight, ms.base.MaxBlockWeight())
 	} else if err := validateV2Siacoins(ms, txn); err != nil {
 		return err

diff --git a/consensus/validation_test.go b/consensus/validation_test.go
@@ -988,6 +988,12 @@ func TestValidateV2Block(t *testing.T) {
 					})
 				},
 			},
+			{
+				"empty v2 transaction",
+				func(b *types.Block) {
+					b.V2.Transactions = append(b.V2.Transactions, types.V2Transaction{})
+				},
+			},
 			{
 				"wrong parent ID",
 				func(b *types.Block) {