Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be explicit about subsidy existence #208

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Be explicit about subsidy existence #208

merged 1 commit into from
Sep 26, 2024

Conversation

n8maninger
Copy link
Member

No description provided.

lukechampine
lukechampine approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@lukechampine lukechampine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though probably the docstring should be updated as well. You could just delete the second line; the exists in the function signature implies that the output is only valid when it's true.

@n8maninger n8maninger merged commit 2c8b541 into master Sep 26, 2024
10 checks passed
@n8maninger n8maninger deleted the foundation-subsidy-check branch September 26, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechampine lukechampine lukechampine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n8maninger @lukechampine