Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefixes #224

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Remove prefixes #224

merged 3 commits into from
Oct 29, 2024

Conversation

n8maninger
Copy link
Member

When working with these types the context is usually known. The prefixes make storing and comparing hex strings more difficult. Removes the prefixes from the all of the hex types except for UnlockKey and PublicKey.

@lukechampine
Copy link
Member

goodnight sweet prince. 😔 It was a promising idea, but in practice the costs outweighed the benefits.

@n8maninger n8maninger merged commit 9fe97b7 into master Oct 29, 2024
7 checks passed
@n8maninger n8maninger deleted the nate/remove-prefixes branch October 29, 2024 22:19
Alrighttt added a commit to KomodoPlatform/sia-rust that referenced this pull request Nov 15, 2024


Prior to this change Hash256 was represented as "h:<32 byte hex string>"

It is now represented as a plain hex string with no prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants