Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhp4): Include storage cost in renter renewal cost #252

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger commented Dec 10, 2024

Slightly different implementation of #251 that does not change the function signature

@n8maninger n8maninger force-pushed the nate/fix-renewal-cost branch from 3698294 to 0534a59 Compare December 10, 2024 22:49
rhp/v4/rhp_test.go Outdated Show resolved Hide resolved
rhp/v4/rhp_test.go Show resolved Hide resolved
rhp/v4/rhp_test.go Show resolved Hide resolved
rhp/v4/rhp_test.go Show resolved Hide resolved
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nothing but nits. I'll leave it for Chris to approve

rhp/v4/rhp_test.go Show resolved Hide resolved
rhp/v4/rhp_test.go Show resolved Hide resolved
rhp/v4/rhp_test.go Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit 5dc3661 into master Dec 12, 2024
10 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the nate/fix-renewal-cost branch December 12, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants