Fix race #163
Merged
Fix race #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
commented
Jan 23, 2025
.changeset/fixed_syncer_deadlocking_when_connect_is_called_after_close.md
Outdated
Show resolved
Hide resolved
ChrisSchinnerl
commented
Jan 23, 2025
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
from
b0c2401 to
9ad13ec
Compare
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
2 times, most recently
from
71bc0b2 to
266526b
Compare
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
from
266526b to
7068ca6
Compare
ChrisSchinnerl
commented
Jan 23, 2025
n8maninger
reviewed
Jan 23, 2025
n8maninger
reviewed
Jan 23, 2025
n8maninger
reviewed
Jan 23, 2025
n8maninger
reviewed
Jan 23, 2025
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
from
a0fb68f to
9f52bec
Compare
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
from
9f52bec to
4f0381e
Compare
n8maninger
reviewed
Jan 24, 2025
ChrisSchinnerl
force-pushed
the
chris/fix-race
branch
from
bbd4c36 to
b0b1afa
Compare
peterjan
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
Fixes race in
handleRPCRenewContractandhandleRPCRefreshContractwhich seems to occur due to the ephemeral contractor sharing its internal state without deep-copying.