Handle cases where guessit returns a list for a show name

[offbyone]

Works around the impact of guessit-io/guessit#770

Proposed changes in this pull request:

• Add some tests for the sanitize name functions based on current behaviour

• When full_sanitizeSceneName receives an iterable that is not a string, turn it into one first.

• A tiny tweak to the pyproject.toml so that ruff will respect the project line length too

• PR is based on the DEVELOP branch

• Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

• Read contribution guide

This is the log message / traceback I'm addressing:

AA AttributeError: 'list' object has no attribute 'replace'
AA ^^^^^^^^^^^^
AA name = name.replace(x, "")
AA File "/app/sickchill/lib/python3.11/site-packages/sickchill/oldbeard/helpers.py", line 668, in sanitizeSceneName
AA ^^^^^^^^^^^^^^^^^^^^^^^
AA return re.sub("[. -]", " ", sanitizeSceneName(name)).lower().strip()
AA File "/app/sickchill/lib/python3.11/site-packages/sickchill/oldbeard/helpers.py", line 855, in full_sanitizeSceneName
AA ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AA name = helpers.full_sanitizeSceneName(name)
AA File "/app/sickchill/lib/python3.11/site-packages/sickchill/oldbeard/name_cache.py", line 37, in get_id_from_name
AA ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AA cache = sickchill.oldbeard.name_cache.get_id_from_name(name)
AA File "/app/sickchill/lib/python3.11/site-packages/sickchill/oldbeard/helpers.py", line 885, in get_show

Summary by CodeRabbit

• New Features
  • Enhanced the app's ability to process non-string iterable inputs in scene name sanitization.
• Refactor
  • Improved organization and import structure in helper functions.
• Tests
  • Removed skip decorators on certain tests, enabling them to run.
  • Added new test cases for scene name sanitization functions.
• Chores
  • Configured code styling tool with updated settings.

[coderabbitai]

Walkthrough

The recent updates aim to enhance the codebase by adjusting configurations, optimizing imports, and improving function behaviors. Notable changes include extending the line length for the ruff tool and refining how non-string iterables are handled in functions within the helpers.py file. The test suite has also been expanded to encompass new scenarios.

Changes

File Path	Change Summary
pyproject.toml	Added ruff tool config with line-length set to 160.
sickchill/.../helpers.py	Reordered imports, added Iterable import, modified function behavior, and expanded test coverage.

🐇✨
O hark! A change doth come, swift and neat,
With lines aligned and imports so sweet.
Code refined, tests anew,
A rabbit hops through, leaving clues.
Celebrate each line and loop,
For cleaner code makes the coder swoop!
🌟📜

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[miigotu]

You have to try and except here and try collections.abc.Iterable and collections.iterable. The aliases moved in python 3.9 -> 3.10.

[miigotu]

Also, the fake_is_active fix is in a comment I made in the other PR @BKSteve

[miigotu]

Replaced by #8759

[miigotu]

@offbyone if you want to add those tests to test_guessit_findit that would be dope