[MIRROR] Alliance United Flotilla branch, and some consistency tweaks to others #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lexanx
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34814
🆑 JuneauQT
rscadd: Added the Alliance United Flotillas Branch and three ranks for it to ID cards (and all other places Branch can be set.)
tweak: ICCGN and SCGA ranks now have their officer/enlisted badge included in their define.
/:cl:
Adds the AUF Branch to the faction options, with three ranks for your adminbus or antaggery pleasure. Also adds Enlisted and Officer pins to the defines of the ICCGN and SCGA ranks, for consistency with the fleet ones.
The sort_orders for the AUF ranks are based off of the torch ones instead of the SCGA or ICCGN's multiples-of-10 system, but the other pack factions have been left untouched aside from giving them the pins in the defines since I assume there's a reason they're set up like that.
I know that the Alliance 'Ranks' aren't that formal a system (maybe they shouldn't have sort_order values set? is that possible?), but I figured it's probably better to have them present as an option for, say, Raiders or admin events than to not.