[MIRROR] allows for single-step crafting recipes to actually make their product #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SierraHelper
force-pushed
the
upstream-pr-34846
branch
from
fff19f6 to
d207367
Compare
Lexanx
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34846
🆑Merlin1230
bugfix: Makeshift splints are now fixed and can be made again by applying tape to a rod
/:cl:
fixes Baystation12#34721
As far as I can tell, the issue came from the fact that crafting code only had the advance part that made the product on the crafting holder, meaning it could only make it if it was able to progress a step after the crafting holder was made. The only crafting recipe that started and ended on the same step was the splint, so thats the only recipe that broke.
As a side note, there is another issue with the splint recipe, mainly that it will use the entire stack of rods to make one splint, so if you dont want to waste a bunch of rods you have to split a rod off the stack. The tricky part about fixing this is that the crafting datums only have variables to control how much is consumed on one side, and its already being used to stop the tape from being consumed, so you cant quite just swap the sides around. Aka, it would need a refactor to stop it from happening, which I would've done if executive dysfunction didnt hit me.