Skip to content

Commit

Permalink
Fix values for k8s-infra (#484)
Browse files Browse the repository at this point in the history
The decision to change the default settings for logging and OTLP
exporters, reportedly due to CI concerns, seems misguided. The OTLP
exporter should remain enabled by default. Users of k8s-infra should
have their data collected and sent to SigNoz or other OTLP backends.
With current defaults, users will not have any idea that their data is
being collected but not sent anywhere.

Being able to perform simple install and provide an endpoint to send
data is a great onboarding experience and we should strive to keep the
experience simple with sensible defaults.
  • Loading branch information
srikanthccv authored Aug 20, 2024
1 parent 9f82ff0 commit 7f6b09a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ jobs:
if: steps.list-changed.outputs.changed == 'true'

- name: Run chart-testing (install)
run: ct install --config ct.yaml
run: ct install --config ct.yaml --helm-extra-set-args '--set=otelCollectorEndpoint=endpoint-that-does-not-exist:4317'
if: steps.list-changed.outputs.changed == 'true'
4 changes: 2 additions & 2 deletions charts/k8s-infra/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,15 @@ namespace: ""
# -- Presets to easily set up OtelCollector configurations.
presets:
loggingExporter:
enabled: true
enabled: false
# Verbosity of the logging export: basic, normal, detailed
verbosity: basic
# Number of messages initially logged each second
samplingInitial: 2
# Sampling rate after the initial messages are logged
samplingThereafter: 500
otlpExporter:
enabled: false
enabled: true
logsCollection:
enabled: true
startAt: beginning
Expand Down

0 comments on commit 7f6b09a

Please sign in to comment.