fix: update order by logic

SigNoz · Nov 13, 2024 · 2698097 · 2698097
1 parent 097a54b
commit 2698097
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/query-service/app/traces/v4/query_builder.go b/pkg/query-service/app/traces/v4/query_builder.go
@@ -191,7 +191,7 @@ func orderByAttributeKeyTags(panelType v3.PanelType, items []v3.OrderBy, tags []
 	if len(orderByArray) == 0 {
 		if panelType == v3.PanelTypeList {
 			orderByArray = append(orderByArray, constants.TIMESTAMP+" DESC")
-		} else if panelType == v3.PanelTypeGraph {
+		} else {
 			orderByArray = append(orderByArray, "value DESC")
 		}
 	}

diff --git a/pkg/query-service/app/traces/v4/query_builder_test.go b/pkg/query-service/app/traces/v4/query_builder_test.go
@@ -349,7 +349,7 @@ func Test_orderByAttributeKeyTags(t *testing.T) {
 				items:     []v3.OrderBy{{ColumnName: "timestamp", Order: "DESC"}},
 				tags:      []v3.AttributeKey{},
 			},
-			want: "",
+			want: "value DESC",
 		},
 		{
 			name: "add default order by ts for list panel",
@@ -376,7 +376,7 @@ func Test_orderByAttributeKeyTags(t *testing.T) {
 				items:     []v3.OrderBy{},
 				tags:      []v3.AttributeKey{},
 			},
-			want: "",
+			want: "value DESC",
 		},
 	}
 	for _, tt := range tests {