Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hoc to support markdown content with variable interpolation #3667

Merged
merged 5 commits into from
Oct 11, 2023
Merged

feat: hoc to support markdown content with variable interpolation #3667

merged 5 commits into from
Oct 11, 2023

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Oct 4, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Oct 4, 2023
@request-info
Copy link

request-info bot commented Oct 4, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@YounixM YounixM force-pushed the markdown-renderer-with-variable-support branch from 3413f11 to 75c32e7 Compare October 10, 2023 15:57
@YounixM YounixM marked this pull request as ready for review October 10, 2023 15:57
@YounixM YounixM requested a review from palashgdev as a code owner October 10, 2023 15:57
@YounixM YounixM requested a review from Rajat-Dabade October 10, 2023 16:02
Rajat-Dabade
Rajat-Dabade reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, we can take this in separate PR, Everything else LGTM 👍

frontend/src/api/settings/getIngestionData.ts Outdated Show resolved Hide resolved
frontend/src/api/settings/getIngestionData.ts Outdated Show resolved Hide resolved
frontend/src/components/MarkdownRenderer/MarkdownRenderer.tsx Show resolved Hide resolved
frontend/src/components/MarkdownRenderer/MarkdownRenderer.tsx Show resolved Hide resolved
frontend/src/container/IngestionSettings/IngestionSettings.tsx Outdated Show resolved Hide resolved
frontend/src/container/IngestionSettings/IngestionSettings.tsx Outdated Show resolved Hide resolved
frontend/src/container/IngestionSettings/IngestionSettings.tsx Show resolved Hide resolved
frontend/src/container/IngestionSettings/IngestionSettings.tsx Show resolved Hide resolved
frontend/src/container/OnboardingContainer/APM/APM.tsx Show resolved Hide resolved
frontend/src/container/IngestionSettings/IngestionSettings.tsx Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

palashgdev
palashgdev approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YounixM YounixM force-pushed the markdown-renderer-with-variable-support branch from aa09b55 to 26c1c04 Compare October 11, 2023 09:40
@YounixM YounixM merged commit 0d3cbb1 into develop Oct 11, 2023
@palashgdev palashgdev deleted the markdown-renderer-with-variable-support branch October 11, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade left review comments

@palashgdev palashgdev palashgdev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YounixM @CLAassistant @Rajat-Dabade @palashgdev