Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update logic to conditionally show Get Started and Billing routes #3807

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Oct 25, 2023

No description provided.

@YounixM YounixM requested a review from palashgdev as a code owner October 25, 2023 20:24
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Oct 25, 2023
@request-info
Copy link

request-info bot commented Oct 25, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

palashgdev
palashgdev previously approved these changes Oct 26, 2023
@palashgdev palashgdev force-pushed the fix-get-started-routing-viewer-role branch from e3de9c0 to 7c466f3 Compare October 26, 2023 07:21
@YounixM YounixM force-pushed the fix-get-started-routing-viewer-role branch from 7c466f3 to de0a2ca Compare October 26, 2023 07:22
Rajat-Dabade
Rajat-Dabade previously approved these changes Oct 26, 2023
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, everything else LGTM.

frontend/src/container/SideNav/SideNav.tsx Outdated Show resolved Hide resolved
@YounixM YounixM force-pushed the fix-get-started-routing-viewer-role branch from fa15293 to 3080cba Compare October 26, 2023 10:05
@YounixM YounixM dismissed stale reviews from palashgdev and Rajat-Dabade via 638734c October 26, 2023 11:38
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palashgdev palashgdev merged commit 7de3cec into develop Oct 26, 2023
8 checks passed
@palashgdev palashgdev deleted the fix-get-started-routing-viewer-role branch October 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working request-more-info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants