feat: add feature flag to clickhouse migration

[ANU7MADHAV]

Summary

The issue was that ClickHouse migrations were starting automatically when the server launched. To address this, I implemented a flag feature for conditional migrations. An environment variable, CLICKHOUSE_MIGRATION_ENABLED, was introduced with a default value of false. When set to false, migrations do not run; if changed to true, migrations will execute. This allows for an optimized, dynamic approach to managing migrations.

Related Issues / PR's

resolves #5678

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Adds a feature flag to conditionally execute ClickHouse migrations based on an environment variable.

• Behavior:
  • Introduces CLICKHOUSE_MIGRATION_ENABLED environment variable to control ClickHouse migrations.
  • If false (default), migrations are skipped; if true, migrations are executed.
• Functions:
  • Adds IsClickhouseMigrationEnable() in constants.go to check the environment variable.
  • Updates ClickHouseMigrate() in migrate.go to accept a config parameter and conditionally execute migrations.
• Server Initialization:
  • Modifies NewServer() in server.go in both ee/query-service/app and pkg/query-service/app to use the new feature flag for migrations.

^{This description was created by for aae2372. It will automatically update as commits are pushed.}

[welcome]

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ prashant-shahi
❌ ANU7MADHAV
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to aae2372 in 56 seconds

More details

• Looked at 76 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. ee/query-service/app/server.go:198

• Draft comment:
  The function name IsClickhouseMigrationEnable should be IsClickhouseMigrationEnabled for consistency and clarity.
• Reason this comment was not posted:
  Marked as duplicate.

2. pkg/query-service/constants/constants.go:153

• Draft comment:
  The function name should be IsClickhouseMigrationEnabled for consistency with naming conventions.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function IsClickhouseMigrationEnable is correctly placed in the constants file, as it deals with environment variables and configuration constants. However, the function name should be IsClickhouseMigrationEnabled to maintain consistency with the naming convention used in the rest of the codebase.

3. pkg/query-service/app/server.go:168

• Draft comment:
  The feature flag for ClickHouse migrations is correctly implemented, resolving the issue described in the PR.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR correctly implements the feature flag for ClickHouse migrations, ensuring that migrations only run when the environment variable is set to true. This resolves the issue described in the PR.

Workflow ID: wflow_ZVMZ6TrViQkrXuAR

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[eKuG]

LGTM, you can ask @srikanthccv for a review as well