chore: use the license v2 key to fill licenses v3 on startup #6468
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 1d4d42f in 1 minute and 9 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Z1UHQEkqRdoM1z5u
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a75b4f8 in 12 seconds
More details
- Looked at
33lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. ee/query-service/license/manager.go:80
- Draft comment:
The error handling forvalidate.ValidateLicenseV3andm.repo.InsertLicenseV3is repetitive. Consider using a helper function to handle errors, reducing code duplication. - Reason this comment was not posted:
Confidence changes required:50%
The error handling forvalidate.ValidateLicenseV3andm.repo.InsertLicenseV3is repetitive. It can be improved by using a helper function to handle errors, reducing code duplication.
Workflow ID: wflow_QxCN3NXD3YfzRCCP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
contributes to - https://github.com/SigNoz/engineering-pod/issues/1035 |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b1cd933 in 9 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. ee/query-service/license/manager.go:88
- Draft comment:
Consider logging a more specific error message whenInsertLicenseV3fails for reasons other thanErrorConflict. This will help in debugging issues more effectively. - Reason this comment was not posted:
Confidence changes required:50%
The error handling forInsertLicenseV3is not consistent with the rest of the codebase. It should return a more specific error message.
Workflow ID: wflow_2xrGZy5ckVow7qz9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas