Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update http proxy middleware #6486

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Nov 20, 2024

Update http proxy middleware

https://www.npmjs.com/package/http-proxy-middleware -> v2.x to 3.x


Important

Update http-proxy-middleware to 3.0.3 and adjust setupProxy.js for compatibility.

  • Dependencies:
    • Update http-proxy-middleware from 2.0.7 to 3.0.3 in package.json.
  • Code Changes:
    • Change import from createProxyMiddleware to legacyCreateProxyMiddleware in setupProxy.js.
    • Update target URL in setupProxy.js to include /tunnel path.

This description was created by Ellipsis for 33e1caf. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Nov 20, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 33e1caf in 21 seconds

More details
  • Looked at 35 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/setupProxy.js:10
  • Draft comment:
    Ensure that the target URL modification to include /tunnel is intentional. This changes the proxy target path and might affect routing.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from createProxyMiddleware to legacyCreateProxyMiddleware is correct based on the update to version 3.0.3 of http-proxy-middleware. However, the target URL modification might not be intended.

Workflow ID: wflow_xDBJeVp2XmCLzDDQ


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

frontend/src/setupProxy.js Show resolved Hide resolved
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit d7bd72e into develop Nov 20, 2024
15 of 18 checks passed
@YounixM YounixM deleted the chore/update-http-proxy-middleware branch November 20, 2024 09:04
YounixM added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants