-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.59.x #6490
Release/v0.59.x #6490
Conversation
* fix: update static fields and add response structs * fix: update ch names * fix: move models to it's own file
* chore: pass active route with RouteTab's onChangeHandler * chore: add log events to alert history page --------- Co-authored-by: Srikanth Chekuri <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5a70123 in 47 seconds
More details
- Looked at
898
lines of code in21
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. pkg/query-service/model/trace.go:11
- Draft comment:
Ensure that theKind
field's data type (int8
) is correct. It might need to be a string or an enum type for consistency withSpanKind
. - Reason this comment was not posted:
Confidence changes required:50%
The fieldKind
inSpanItemV2
is defined asint8
, but it is unclear if this is the correct data type. TheSpanKind
field is a string, which might suggest thatKind
should also be a string or an enum type. This should be verified to ensure consistency and correctness.
2. frontend/src/components/RouteTab/index.tsx:11
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about the file structure, which is not something that was changed in this diff. The diff only shows a change in the function call within the file, not the file structure itself. Therefore, the comment is not about a change made in this diff.
I might be missing the context of whether the file structure was a concern before this diff. However, the task is to focus on changes made in the diff, and the file structure was not changed.
Even if the file structure is a concern, it is not relevant to the specific changes made in this diff, so the comment should not be kept.
The comment is not about a change made in this diff, so it should be deleted.
Workflow ID: wflow_arXUUfOlOczjYYPL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Important
Update SigNoz to v0.59.0 and OtelCollector to v0.111.9, with changes in API routes, logging, and constants.
docker-compose.yaml
,docker-compose-core.yaml
,docker-compose-minimal.yaml
, anddocker-compose.testing.yaml
.docker-compose.yaml
,docker-compose-core.yaml
,docker-compose-minimal.yaml
, anddocker-compose.testing.yaml
.AdminAccess
toEditAccess
inapi.go
.ZeusURL
constant inconstants.go
and set via build time variable.TopContributorsRows.tsx
andTable.tsx
.AlertDetails.tsx
.http-proxy-middleware
to v3.0.3 inpackage.json
.createProxyMiddleware
tolegacyCreateProxyMiddleware
insetupProxy.js
.onChangeHandler
signature inRouteTab
component.signoz-otel-collector
dependency to v0.111.9 ingo.mod
andgo.sum
.SpanItemV2
andTraceSummary
structs intrace.go
.StaticFieldsTraces
inconstants.go
to include new and deprecated fields.This description was created by for 5a70123. It will automatically update as commits are pushed.