Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.59.x #6490

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Release/v0.59.x #6490

merged 8 commits into from
Nov 20, 2024

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Nov 20, 2024

Summary

  • release SigNoz v0.59.0
  • bump up SigNoz OtelCollector v0.111.9

Important

Update SigNoz to v0.59.0 and OtelCollector to v0.111.9, with changes in API routes, logging, and constants.

  • Version Updates:
    • Update SigNoz to v0.59.0 in docker-compose.yaml, docker-compose-core.yaml, docker-compose-minimal.yaml, and docker-compose.testing.yaml.
    • Update SigNoz OtelCollector to v0.111.9 in docker-compose.yaml, docker-compose-core.yaml, docker-compose-minimal.yaml, and docker-compose.testing.yaml.
  • API and Constants:
    • Change API route access from AdminAccess to EditAccess in api.go.
    • Add ZeusURL constant in constants.go and set via build time variable.
  • Logging and Event Tracking:
    • Add logging for row clicks in TopContributorsRows.tsx and Table.tsx.
    • Add tab change logging in AlertDetails.tsx.
  • Frontend Changes:
    • Update http-proxy-middleware to v3.0.3 in package.json.
    • Change createProxyMiddleware to legacyCreateProxyMiddleware in setupProxy.js.
    • Modify onChangeHandler signature in RouteTab component.
  • Go Modifications:
    • Update signoz-otel-collector dependency to v0.111.9 in go.mod and go.sum.
    • Add SpanItemV2 and TraceSummary structs in trace.go.
    • Refactor StaticFieldsTraces in constants.go to include new and deprecated fields.

This description was created by Ellipsis for 5a70123. It will automatically update as commits are pushed.

@prashant-shahi prashant-shahi requested a review from a team as a code owner November 20, 2024 11:19
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5a70123 in 47 seconds

More details
  • Looked at 898 lines of code in 21 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/model/trace.go:11
  • Draft comment:
    Ensure that the Kind field's data type (int8) is correct. It might need to be a string or an enum type for consistency with SpanKind.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The field Kind in SpanItemV2 is defined as int8, but it is unclear if this is the correct data type. The SpanKind field is a string, which might suggest that Kind should also be a string or an enum type. This should be verified to ensure consistency and correctness.
2. frontend/src/components/RouteTab/index.tsx:11
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about the file structure, which is not something that was changed in this diff. The diff only shows a change in the function call within the file, not the file structure itself. Therefore, the comment is not about a change made in this diff.
    I might be missing the context of whether the file structure was a concern before this diff. However, the task is to focus on changes made in the diff, and the file structure was not changed.
    Even if the file structure is a concern, it is not relevant to the specific changes made in this diff, so the comment should not be kept.
    The comment is not about a change made in this diff, so it should be deleted.

Workflow ID: wflow_arXUUfOlOczjYYPL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prashant-shahi prashant-shahi merged commit 71d1e12 into main Nov 20, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants