feat: implement nodes list table in infra monitoring #6615

amlannandy · 2024-12-11T11:06:35Z

Summary

Implement the nodes list table in Infra Monitoring

Related Issues / PR's

N/A

Screenshots

N/A

Affected Areas and Manually Tested Areas

Infra Monitoring section

Important

Implement Kubernetes nodes list feature in Infra Monitoring with new API, UI components, and hooks for data fetching and display.

API:
- Add getK8sNodesList in getK8sNodesList.ts to fetch Kubernetes nodes.
- Define interfaces K8sNodesListPayload, K8sNodesData, and K8sNodesListResponse.
UI Components:
- Add K8sNodesList component in K8sNodesList.tsx for displaying nodes with pagination and sorting.
- Update InfraMonitoringK8s.tsx to include K8sNodesList.
- Modify K8sFiltersSidePanel.tsx and K8sHeader.tsx for dynamic column management.
Hooks:
- Implement useGetK8sNodesList in useGetK8sNodesList.ts for querying nodes list.
Utilities:
- Add utility functions in utils.tsx for data formatting and table columns.
- Update constants.ts to include nodes-related quick filters.

^{This description was created by}^{for dba5695. It will automatically update as commits are pushed.}

github-actions · 2024-12-11T11:06:51Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

amlannandy · 2024-12-11T11:08:10Z

frontend/src/container/InfraMonitoringK8s/utils.tsx

@@ -14,6 +14,13 @@ import {
 } from 'components/QuickFilters/QuickFilters';
 import { DataTypes } from 'types/api/queryBuilder/queryAutocompleteResponse';

+export interface IEntityColumn {


Using this instead of IPodColumn. As we're reusing it, thought it should have a more generic name.
We can remove IPodColumn in the end. I didn't rename it now to avoid conflicts.

amlannandy · 2024-12-11T14:47:33Z

frontend/src/container/InfraMonitoringK8s/K8sHeader.tsx

@@ -127,4 +128,11 @@ function K8sHeader({
 	);
 }

+K8sHeader.defaultProps = {


Made these fields optional for list views where there is no metadata to show

github-actions · 2024-12-19T07:07:57Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-19T07:08:27Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-19T07:09:58Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

❌ Changes requested. Reviewed everything up to 8a1558a in 2 minutes and 7 seconds

More details

Looked at 1006 lines of code in 9 files
Skipped 0 files when reviewing.
Skipped posting 5 drafted comments based on config settings.

1. frontend/src/container/InfraMonitoringK8s/K8sFiltersSidePanel/K8sFiltersSidePanel.tsx:129

Draft comment:
Duplicate default export. Remove one of the export default K8sFiltersSidePanel; statements.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment claims there are duplicate default exports, but I can only see one export default statement in the file. The comment appears to be incorrect. The code follows a common pattern of defining the component, setting its defaultProps, and then exporting it once at the end.
Could there be another export default statement that was removed in this diff that makes this comment relevant to the changes?
Looking at the diff, I can see that the original code did have an export default on the component definition that was removed in favor of the new pattern. However, in the current state of the code, there is no duplicate export.
The comment is incorrect for the current state of the code - there is no duplicate export default. The code has been properly refactored to use a single export.

2. frontend/src/container/InfraMonitoringK8s/K8sHeader.tsx:161

Draft comment:
Duplicate default export. Remove one of the export default K8sHeader; statements.
Reason this comment was not posted:
Comment was on unchanged code.

3. frontend/src/container/InfraMonitoringK8s/Nodes/utils.tsx:82

Draft comment:
The orderBy field uses 'cpu' which does not match any field in K8sNodesData. Ensure the column name is correct.
Reason this comment was not posted:
Comment did not seem useful.

4. frontend/src/container/InfraMonitoringK8s/utils.tsx:11

Draft comment:
The orderBy field uses 'cpu' which does not match any field in K8sPodsData. Ensure the column name is correct.
Reason this comment was not posted:
Comment did not seem useful.

5. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:112

Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components.
Reason this comment was not posted:
Comment looked like it was already resolved.

Workflow ID: wflow_vV8t4Cw8NM6YDObK

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

github-actions · 2024-12-19T07:12:13Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

amlannandy · 2024-12-19T07:15:16Z

frontend/src/container/InfraMonitoringK8s/Nodes/utils.tsx

+			</div>
+		),
+		clusterName: node.meta.k8s_cluster_name,
+		cpuUtilization: node.nodeCPUUsage === -1 ? '-' : node.nodeCPUUsage,


Showing - instead of -1 to denote invalid value

github-actions · 2024-12-19T11:10:32Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Incremental review on 26a6959 in 45 seconds

More details

Looked at 42 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 3 drafted comments based on config settings.

1. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:404

Draft comment:
Consider creating a utility function to handle resetting expandedRowKeys to improve code readability and maintainability. This is applicable in multiple places where setExpandedRowKeys([]) is used.
Reason this comment was not posted:
Confidence changes required: 50%
The setExpandedRowKeys is used in multiple places to reset the expanded rows. It would be more efficient to use a single function to handle this logic, improving code readability and maintainability.

2. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:478

Draft comment:
Consider creating a utility function to handle resetting expandedRowKeys to improve code readability and maintainability. This is applicable in multiple places where setExpandedRowKeys([]) is used.
Reason this comment was not posted:
Confidence changes required: 50%
The expandedRowKeys state is being reset in multiple places. It would be beneficial to have a utility function to handle this logic, which would improve code readability and maintainability.

3. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:480

Draft comment:
Avoid using inline styles for the Spin component. Consider using CSS classes or styled components instead.
Reason this comment was not posted:
Comment was not on a valid diff hunk.

Workflow ID: wflow_vYKGCHCTPSGUmUMa

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

github-actions · 2024-12-24T06:55:28Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-24T08:30:35Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Incremental review on 1b0d029 in 52 seconds

More details

Looked at 191 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 3 drafted comments based on config settings.

1. frontend/src/api/infra/getHostAttributeKeys.ts:24

Draft comment:
Consider making the limit parameter configurable instead of hardcoding it to 500. This will provide more flexibility and potentially improve performance for different use cases.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The limit of 500 seems like a reasonable default that would work for most autocomplete scenarios. Making it configurable would add complexity without clear benefits. There's no evidence that different use cases need different limits. The comment is speculative about "potentially improve performance" without concrete justification.
Maybe there are specific use cases where a different limit would be beneficial. The hardcoded value could become a maintenance issue if requirements change.
Without concrete evidence of different limit requirements or performance issues, adding configuration complexity isn't justified. If needs change, the value can be updated then.
Delete the comment as it suggests adding complexity without clear evidence of benefit. The hardcoded 500 limit is reasonable for autocomplete.

2. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:317

Draft comment:
The showHeader property is set to false, which hides the table headers. Ensure this is the intended behavior, as headers are typically important for data tables.
Reason this comment was not posted:
Confidence changes required: 50%
In K8sNodesList.tsx, the showHeader property of the Table component is set to false. This might not be the intended behavior as it hides the table headers, which are usually important for understanding the data being displayed.

3. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.tsx:317

Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable to other inline styles in this file.
Reason this comment was not posted:
Comment was on unchanged code.

Workflow ID: wflow_H93uRSdOk7nJ9bvj

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

feat: implement node details page

github-actions · 2024-12-27T04:05:12Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Incremental review on 186f768 in 1 minute and 34 seconds

More details

Looked at 339 lines of code in 13 files
Skipped 0 files when reviewing.
Skipped posting 8 drafted comments based on config settings.

1. frontend/src/container/InfraMonitoringK8s/Nodes/K8sNodesList.styles.scss:8

Draft comment:
Avoid using !important in CSS unless absolutely necessary. It makes the code harder to maintain and override.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The use of !important here seems deliberate to ensure consistent table column widths, likely fighting against Ant Design's default table styles. While generally avoiding !important is good practice, in cases of overriding third-party component styles it's often necessary. Without seeing the actual rendering and style conflicts, we can't be certain if there's a better alternative.
I might be too lenient on accepting !important when dealing with third-party components. There could be alternative approaches using more specific selectors or component customization.
While alternatives might exist, the comment doesn't provide specific actionable solutions, and !important is a common necessity when working with third-party UI libraries like Ant Design.
Delete the comment as it's not providing clear actionable feedback, and the use of !important appears intentional for overriding third-party component styles.

2. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/Events/NodeEvents.tsx:80

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Comment did not seem useful.

3. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/Logs/NodeLogsDetailedView.tsx:53

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Marked as duplicate.

4. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/Traces/NodeTraces.tsx:70

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Marked as duplicate.

5. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/Events/Events.tsx:80

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Marked as duplicate.

6. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodLogs/PodLogsDetailedView.tsx:53

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Marked as duplicate.

7. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodTraces/PodTraces.tsx:70

Draft comment:
Avoid using as any for type casting. Ensure filters is correctly typed and initialized.
Reason this comment was not posted:
Marked as duplicate.

8. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/NodeDetails.tsx:95

Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead.
Reason this comment was not posted:
Comment was not on a valid diff hunk.

Workflow ID: wflow_8ZdfvAp2H7ursDOl

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

github-actions · 2024-12-27T07:33:37Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

❌ Changes requested. Incremental review on 9a57f08 in 1 minute and 11 seconds

More details

Looked at 239 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 1 drafted comments based on config settings.

1. frontend/src/container/InfraMonitoringK8s/commonUtils.tsx:108

Draft comment:
The EntityProgressBar uses getStrokeColorForLimitUtilization, which might not be appropriate for request utilization. Consider using getStrokeColorForRequestUtilization for request progress bars to maintain consistent visual representation.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
Without more context about how EntityProgressBar is used, we can't know if it's meant for requests or limits. The name is generic and could be used for either. The comment is speculative ("might not be appropriate") rather than definitive. We don't have enough evidence to know if this is actually incorrect.
The comment could be correct - if EntityProgressBar is used for requests, using the limit colors would be wrong. We're missing the usage context.
Per the rules, we should delete speculative comments and comments that require more context to validate. The comment uses "might" language and we can't verify the correct behavior.
Delete the comment since it's speculative and we lack the context to verify if it's actually incorrect.

Workflow ID: wflow_WS9bXdpQVWDvcAHX

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-12-27T07:34:05Z

frontend/src/container/InfraMonitoringK8s/commonUtils.tsx

+				className="progress-bar"
+				showInfo={false}
+			/>
+			<Typography.Text style={{ fontSize: '10px' }}>{percentage}%</Typography.Text>


Avoid using inline styles. Consider using CSS classes or styled components instead.

github-actions · 2024-12-27T11:40:53Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

❌ Changes requested. Incremental review on dba5695 in 1 minute and 25 seconds

More details

Looked at 273 lines of code in 10 files
Skipped 0 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_AcwUgzo1SEUYbQTf

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-12-27T11:41:21Z

frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodTraces/PodTraces.tsx

 					},
 				],
 			},
 		}),
 		[currentQuery],
 	);

+	console.log({ updatedCurrentQuery });


Remove console.log statement to avoid cluttering the console in production.

github-actions bot added the enhancement New feature or request label Dec 11, 2024

amlannandy commented Dec 11, 2024

View reviewed changes

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch 2 times, most recently from ea32f5e to 0bbd4d0 Compare December 18, 2024 12:55

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from f8b95d1 to efd5c2c Compare December 18, 2024 18:13

amlannandy marked this pull request as ready for review December 19, 2024 07:07

amlannandy requested a review from YounixM as a code owner December 19, 2024 07:07

ellipsis-dev bot reviewed Dec 19, 2024

View reviewed changes

amlannandy commented Dec 19, 2024

View reviewed changes

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from 8a1558a to c951cd0 Compare December 19, 2024 10:24

ellipsis-dev bot reviewed Dec 19, 2024

View reviewed changes

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from 26a6959 to b5d57e1 Compare December 19, 2024 12:44

SigNoz deleted a comment from ellipsis-dev bot Dec 19, 2024

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from b5d57e1 to ba944d0 Compare December 24, 2024 06:53

ellipsis-dev bot reviewed Dec 24, 2024

View reviewed changes

amlannandy added 6 commits December 27, 2024 09:34

feat: implement nodes list table in infra-monitoring

ee1bdc7

chore: update header props

1973058

chore: update columns

94e8e82

chore: add cluster name column

e649b45

chore: update props

ddc2b5b

feat: implement group-by and quick select in node list table

5c78e68

amlannandy and others added 7 commits December 27, 2024 09:34

feat: implement nested view

6046e2d

chore: styling changes

a360b2e

chore: fix expand issues

354573e

chore: fix bugs in node listing

da8e4c9

feat: implement node details page (#6641)

a371241

feat: implement node details page

chore: fix issues in pods

4526f7c

chore: fix issues in nodes

6d441f3

amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from 186f768 to 6d441f3 Compare December 27, 2024 04:04

ellipsis-dev bot reviewed Dec 27, 2024

View reviewed changes

chore: fix table alignment issues

9a57f08

ellipsis-dev bot reviewed Dec 27, 2024

View reviewed changes

chore: fix filters issue

dba5695

ellipsis-dev bot reviewed Dec 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement nodes list table in infra monitoring #6615

feat: implement nodes list table in infra monitoring #6615

amlannandy commented Dec 11, 2024 •

edited by ellipsis-dev bot

Loading

github-actions bot commented Dec 11, 2024

amlannandy Dec 11, 2024

amlannandy Dec 11, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

ellipsis-dev bot left a comment

github-actions bot commented Dec 19, 2024

amlannandy Dec 19, 2024

github-actions bot commented Dec 19, 2024

ellipsis-dev bot left a comment

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

ellipsis-dev bot left a comment

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Dec 27, 2024

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot Dec 27, 2024

feat: implement nodes list table in infra monitoring #6615

Are you sure you want to change the base?

feat: implement nodes list table in infra monitoring #6615

Conversation

amlannandy commented Dec 11, 2024 • edited by ellipsis-dev bot Loading

Summary

Related Issues / PR's

Screenshots

Affected Areas and Manually Tested Areas

github-actions bot commented Dec 11, 2024

amlannandy Dec 11, 2024

Choose a reason for hiding this comment

amlannandy Dec 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024

amlannandy Dec 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Dec 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot Dec 27, 2024

Choose a reason for hiding this comment

amlannandy commented Dec 11, 2024 •

edited by ellipsis-dev bot

Loading