Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flag): add missing flag back #6647

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(flag): add missing flag back #6647

merged 1 commit into from
Dec 16, 2024

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Dec 16, 2024

Summary

add missing flag back


Important

Add missing useLicensesV3 flag in main.go to control licenses_v3 schema usage.

  • Flags:
    • Add missing useLicensesV3 flag in main.go to control the use of licenses_v3 schema.

This description was created by Ellipsis for 0aa2057. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Dec 16, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0aa2057 in 11 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/main.go:123
  • Draft comment:
    The use-licenses-v3 flag is defined but not used anywhere in the code. Ensure that this flag is utilized where necessary or remove it if it's not needed.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. ee/query-service/main.go:123
  • Draft comment:
    The code changes in this PR do not violate any of the specified rules. The addition of the useLicensesV3 flag is appropriate and does not introduce any issues related to the rules provided.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code changes in the PR do not violate any of the specified rules. The addition of the flag is appropriate and does not introduce any issues related to the rules provided.

Workflow ID: wflow_MtgQJsnZXGjgAQg7


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv merged commit 14fbb1f into develop Dec 16, 2024
17 of 19 checks passed
@srikanthccv srikanthccv deleted the add-redundant-flag branch December 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants