feat: added span_count using the MV and index v3 traces table [Design needs to be finalised]

[eKuG]

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Added support for sorting trace queries by span count using a new sortBy parameter in query functions.

• Behavior:
  • Added sortBy parameter to prepareTracesQueryFunc in query_builder.go to support sorting by span count.
  • Updated PrepareTracesQuery in query_builder.go, v3/query_builder.go, and v4/query_builder.go to handle sortBy parameter.
  • Introduced TraceSortBySpanCount and TraceSortByTraceDuration constants in constants.go.
• Query Building:
  • Modified buildTracesQuery in v3/query_builder.go and v4/query_builder.go to include logic for sorting by span count using TraceExplorerSpanCountSubQuery.
  • Adjusted query logic to use SIGNOZ_TRACE_SPAN_COUNT_MV for span count sorting.
• Models:
  • Added SortBy field to QueryRangeParamsV3 in v3.go.

^{This description was created by for cdeb0af. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to cdeb0af in 1 minute and 39 seconds

More details

• Looked at 171 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. pkg/query-service/app/traces/v3/query_builder.go:502

• Draft comment:
  The sortBy parameter is added to the PrepareTracesQuery function signature but is not used within the function. Ensure that sortBy is utilized appropriately to affect the query as intended.
• Reason this comment was not posted:
  Comment did not seem useful.

2. pkg/query-service/app/traces/v4/query_builder.go:387

• Draft comment:
  The sortBy parameter is added to the PrepareTracesQuery function signature but is not used within the function. Ensure that sortBy is utilized appropriately to affect the query as intended.
• Reason this comment was not posted:
  Marked as duplicate.

3. pkg/query-service/app/queryBuilder/query_builder.go:41

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_8s3jLjJQ0k5Q6y9K

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.