fix: handle exists and nexists for mat columns and top level columns

[nityanandagohain]

Fixes #6584

• For materialized columns it uses the exists column
• For top level columns it checks on the value.

---

Important

Improved handling of exists and not exists operators for materialized and top-level columns in query builder with updated tests.

• Behavior:
  • Updated handling of exists and not exists operators for materialized and top-level columns in query_builder.go.
  • Introduced getExistsNexistsFilter() to manage these operators.
• Tests:
  • Updated Test_buildTracesFilterQuery and Test_buildTracesQuery in query_builder_test.go to cover new behavior.
  • Added test cases for exists and not exists operators for both materialized and top-level columns.

^{This description was created by for 2df8d40. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 161f5fd in 2 minutes and 3 seconds

More details

• Looked at 123 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. pkg/query-service/app/traces/v4/query_builder.go:101

• Draft comment:
  Ensure that the column name is properly formatted with backticks. Consider using fmt.Sprintf("%s_exists = %v", strings.TrimSuffix(getColumnName(item.Key), ""), val)` for consistency.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. pkg/query-service/app/traces/v4/query_builder.go:144

• Draft comment:
  Ensure that the getExistsNexistsFilter function handles all possible data types and scenarios correctly. Consider adding more test cases if necessary.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR modifies the handling of 'exists' and 'not exists' operators for materialized columns and top-level columns. The changes in the getExistsNexistsFilter function and its usage in buildTracesFilterQuery and buildTracesQuery are crucial. The test cases in query_builder_test.go should cover these changes to ensure correctness.

3. pkg/query-service/app/traces/v4/query_builder.go:372

• Draft comment:
  Ensure that the getExistsNexistsFilter function is correctly handling the AggregateAttribute when it is a materialized column. Consider adding test cases if necessary.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR modifies the handling of 'exists' and 'not exists' operators for materialized columns and top-level columns. The changes in the getExistsNexistsFilter function and its usage in buildTracesFilterQuery and buildTracesQuery are crucial. The test cases in query_builder_test.go should cover these changes to ensure correctness.

4. pkg/query-service/app/traces/v4/query_builder.go:144

• Draft comment:
  Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This applies to other similar instances in the file.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_XdkiGw2IpfT6p8zC

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 2df8d40 in 32 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. pkg/query-service/app/traces/v4/query_builder.go:103

• Draft comment:
  Ensure that all inputs used in query strings are properly sanitized and validated to prevent SQL injection vulnerabilities.
• Reason this comment was not posted:
  Comment did not seem useful.

2. pkg/query-service/app/traces/v4/query_builder.go:103

• Draft comment:
  Use a consistent approach to handle backticks in string formatting to avoid syntax errors.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_pTpFTgrJ1wLKgbkx

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.