feat: implement deployment details page for infra monitoring #6699
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e8cea7e in 1 minute and 40 seconds
More details
- Looked at
5887lines of code in34files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx:112
- Draft comment:
TheorderByfield usescpu, which might not be a valid column. Verify the column name against the actual data structure. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx:238
- Draft comment:
Ensure that the keys used ingroupByexist indeployment.metato avoid potential errors. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/Traces/utils.tsx:57
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values for consistency. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_aVWZaA37kwwHWebn
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| return options.queryKey; | ||
| } | ||
|
|
||
| return [REACT_QUERY_KEY.GET_HOST_LIST, requestData]; |
There was a problem hiding this comment.
The query key REACT_QUERY_KEY.GET_HOST_LIST seems incorrect for fetching deployments. Consider using a more specific key for deployments.
| return ( | ||
| <div className="pod-group"> | ||
| {groupByValues.map((value) => ( | ||
| <Tag key={value} color="#1D212D" className="pod-group-tag-item"> |
There was a problem hiding this comment.
Use design tokens or predefined color constants instead of hardcoding color values for consistency.
Summary
Implement the deployment details page in Infra Monitoring
Related Issues / PR's
N/A
Screenshots
N/A
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Implement detailed view for Kubernetes deployments in Infra Monitoring, including metrics, logs, traces, and events.
getK8sDeploymentsListingetK8sDeploymentsList.tsto fetch deployment data.useGetK8sDeploymentsListhook inuseGetK8sDeploymentsList.tsfor querying deployment data.DeploymentDetailscomponent inDeploymentDetails.tsxto display deployment metrics, logs, traces, and events.K8sDeploymentsListcomponent inK8sDeploymentsList.tsxfor listing deployments.DeploymentMetrics,DeploymentLogs,DeploymentTraces, andDeploymentEventscomponents for detailed views.DeploymentDetails.styles.scssandK8sDeploymentsList.tsx.utils.tsxfor formatting deployment data and configuring columns.This description was created by
for e8cea7e. It will automatically update as commits are pushed.