Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host ports as config flags #6726

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

bert0RM
Copy link

@bert0RM bert0RM commented Dec 26, 2024

Summary

Adding host port config flags for http, private http, debug http, and opamp servers to allow using ipv6.
Defaults are set to previous constant values.

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Add configuration flags for host ports in main.go and update server.go to use these flags for server initialization.

  • Behavior:
    • Adds configuration flags for http-host-port, private-host-port, debug-host-port, and opamp-ws-endpoint in main.go.
    • Updates ServerOptions in server.go to use these flags instead of constants.
  • Server Initialization:
    • NewServer in server.go now initializes ports using the new flags.
    • Start function in server.go uses serverOptions for port configuration.
  • Misc:
    • Defaults for new flags are set to previous constant values in constants.
    • Minor logging updates in server.go to reflect new port configurations.

This description was created by Ellipsis for d403600. It will automatically update as commits are pushed.

Copy link

welcome bot commented Dec 26, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d403600 in 11 seconds

More details
  • Looked at 81 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/main.go:74
  • Draft comment:
    Ensure that the default values in constants.HTTPHostPort, constants.PrivateHostPort, constants.DebugHttpPort, and constants.OpAmpWsEndpoint are appropriate for IPv6 support.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces new flags for host ports, but the default values are set to constants. This is good for backward compatibility. However, the constants should be checked to ensure they are appropriate for the new functionality, especially regarding IPv6 support.
2. pkg/query-service/main.go:74
  • Draft comment:
    Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This applies to the host ports as well, which are correctly using constants here.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses constants for host ports, which is a good practice for consistency and maintainability.

Workflow ID: wflow_QF92WiEVYwr5MxSm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants