feat: aws integration: UI facing QS api for cloud account management #6771
+1,280
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-0
branch
2 times, most recently
from
202bc43 to
7d576aa
Compare
…enerate-connection-url
…get account status
…getting account status
… in list of connected accounts
…t list after agent check in
…ig after account config update
…n of connection url
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-0
branch
from
7d576aa to
5e1246b
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5e1246b in 1 minute and 53 seconds
More details
- Looked at
1390lines of code in11files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. pkg/query-service/utils/testutils.go:19
- Draft comment:
Consider checking the error returned byos.Removein the cleanup function to ensure the temporary file is successfully deleted. This will help avoid leftover files in the system. - Reason this comment was not posted:
Confidence changes required:50%
The functionNewTestSqliteDBcreates a temporary SQLite database for testing purposes. However, it does not handle the case where the temporary file cannot be removed during cleanup. This could lead to leftover files in the system.
2. pkg/query-service/utils/testutils.go:33
- Draft comment:
The TODO comment suggests that passing the DB file path should not be necessary. Consider refactoring the code to eliminate the need for passing the DB file path todao.InitDaoanddashboards.InitDB. - Reason this comment was not posted:
Confidence changes required:50%
TheNewQueryServiceDBForTestsfunction initializes the DAO and dashboards with the test database file path. However, the TODO comment suggests that passing the DB file path should not be necessary. This indicates a potential area for improvement in the codebase.
3. pkg/query-service/app/cloudintegrations/controller.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Comment was on unchanged code.
4. pkg/query-service/app/cloudintegrations/repo.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
5. pkg/query-service/app/cloudintegrations/model.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
6. pkg/query-service/app/cloudintegrations/controller_test.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_wjestgZYRSegDlj2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
reviewed
Jan 9, 2025
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 26bd4e3 in 34 seconds
More details
- Looked at
56lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. pkg/query-service/app/cloudintegrations/controller.go:227
- Draft comment:
The error message 'couldn't disconnect account' is appropriate here as it aligns with the operation being performed. - Reason this comment was not posted:
Confidence changes required:10%
The error message in the DisconnectAccount function should be consistent with the operation being performed. The current message 'couldn't disconnect account' is appropriate for the context of the operation.
2. pkg/query-service/app/cloudintegrations/controller.go:235
- Draft comment:
The error message 'couldn't disconnect account' is appropriate here as it aligns with the operation being performed. - Reason this comment was not posted:
Confidence changes required:10%
The error message in the DisconnectAccount function should be consistent with the operation being performed. The current message 'couldn't disconnect account' is appropriate for the context of the operation.
3. pkg/query-service/app/cloudintegrations/controller_test.go:99
- Draft comment:
The test correctly checks for an error when disconnecting a non-existent account. The assertions are appropriate. - Reason this comment was not posted:
Confidence changes required:10%
The test function TestCantDisconnectNonExistentAccount is correctly checking for the error when trying to disconnect a non-existent account. The assertions are appropriate and ensure the function behaves as expected.
4. pkg/query-service/app/cloudintegrations/controller.go:222
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This is also applicable in other parts of the code where inline styles are used. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_DkNLsRrpyLyU4I9I
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…ount with 2 signoz ids
…nt with 2 signoz ids
raj-k-singh
commented
Jan 9, 2025
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2ff511e in 1 minute and 26 seconds
More details
- Looked at
59lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/app/cloudintegrations/controller_test.go:125
- Draft comment:
The test caseTestAgentCheckInswas updated to expectapiErrto benilafter a successful check-in, which aligns with the changes in theCheckInAsAgentfunction. This is a correct change. - Reason this comment was not posted:
Confidence changes required:20%
The test caseTestAgentCheckInswas modified to expectapiErrto benilafter a successful check-in, which aligns with the changes in theCheckInAsAgentfunction. This is a correct change, but it should be noted for clarity.
Workflow ID: wflow_gtGjfF3MjgAtKKTF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
previously approved these changes
Jan 9, 2025
|
@raj-k-singh please check the ee references in MIT licensed code error |
…egrations controller
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 35e1027 in 24 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_3QvIQ6Zt6jFLa23z
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
@srikanthccv it was a mistaken import of ee/model instead of pkg/model by the IDE. Please take a look and approve again |
srikanthccv
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Query Service APIs for powering AWS integrations UI
Related Issues / PR's
Contributes to #6544
Important
Add AWS cloud account management API to Query Service with new routes, controllers, models, and tests.
RegisterCloudIntegrationsRoutesinhttp_handler.goto handle AWS cloud account management.CloudIntegrationsControllerincontroller.gofor managing cloud accounts.ListConnectedAccounts,GenerateConnectionUrl,GetAccountStatus,CheckInAsAgent,UpdateAccountConfig, andDisconnectAccount.AccountRecord,AccountConfig,AgentReportinmodel.go.cloudProviderAccountsSQLRepositoryinrepo.gofor database operations.CloudIntegrationsControllerinserver.goduring server initialization.signoz_cloud_integrations_test.goto verify AWS integration lifecycle.NewTestSqliteDBintestutils.gofor testing purposes.This description was created by
for 35e1027. It will automatically update as commits are pushed.