Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat: updated the logic for variable update queue" #6781

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jan 8, 2025

Reverts #6586


Important

Reverts variable update queue logic, removing dependency management and associated tests.

  • Revert Changes:
    • Reverts logic for variable update queue in DashboardVariableSelection.tsx.
    • Removes dependency management functions and state handling.
    • Deletes tests related to dependency graph in VariableItem.test.tsx.
  • Code Simplification:
    • Removes dependencyData state and related logic.
    • Simplifies onValueUpdate and onVarChanged functions.
    • Eliminates buildDependencies, buildDependencyGraph, and checkAPIInvocation functions from util.ts.
  • Testing:
    • Removes tests for dependency graph utilities in dashboardVariables.test.tsx and mock.ts.

This description was created by Ellipsis for c2bbd09. It will automatically update as commits are pushed.

@github-actions github-actions bot added the enhancement New feature or request label Jan 8, 2025
@vikrantgupta25 vikrantgupta25 changed the title Revert "feat: updated the logic for variable update queue" fix: revert "feat: updated the logic for variable update queue" Jan 8, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c2bbd09 in 1 minute and 28 seconds

More details
  • Looked at 1110 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/NewDashboard/DashboardVariablesSelection/util.ts:3
  • Draft comment:
    The areArraysEqual function only performs a shallow comparison. Consider using a deep comparison method if arrays can contain objects or nested arrays.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx:139
  • Draft comment:
    Avoid using inline styles in React components. Consider using external stylesheets, CSS classes, or styled components instead.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_nB8BSctoOo3pTFKD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25 vikrantgupta25 enabled auto-merge (squash) January 8, 2025 19:30
@vikrantgupta25 vikrantgupta25 merged commit 56b17bc into main Jan 8, 2025
20 of 21 checks passed
@vikrantgupta25 vikrantgupta25 deleted the revert-6586-variable-update-queue branch January 8, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants