Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle off infra monitoring #6787

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Jan 9, 2025

Summary

Toggle off infra monitoring feature

Related Issues / PR's

Screenshots

Screenshot 2025-01-09 at 7 29 09 PM

Affected Areas and Manually Tested Areas

Infra Monitoring section


Important

Remove Kubernetes from routes in InfrastructureMonitoringPage.tsx to disable Kubernetes infra monitoring.

  • Behavior:
    • Removed Kubernetes from routes array in InfrastructureMonitoringPage.tsx, disabling Kubernetes infra monitoring.

This description was created by Ellipsis for 9c01cec. It will automatically update as commits are pushed.

@amlannandy amlannandy requested a review from YounixM as a code owner January 9, 2025 13:58
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added enhancement New feature or request docs required labels Jan 9, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9c01cec in 15 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoringPage.tsx:8
  • Draft comment:
    Ensure that removing the Kubernetes import does not affect other parts of the codebase that might rely on it.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for Kubernetes is removed, but there might be other parts of the codebase that still reference it. It's important to ensure that removing this import doesn't break any functionality.
2. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoringPage.tsx:5
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_e5mhbCMxRFZqIvWT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@amlannandy amlannandy force-pushed the feat/infra-monitoring-fix branch from 9c01cec to 439500c Compare January 9, 2025 14:03
@amlannandy amlannandy merged commit f91badb into main Jan 9, 2025
16 checks passed
@amlannandy amlannandy deleted the feat/infra-monitoring-fix branch January 9, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants