Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default cloud plan text to Teams Cloud and Teams #6790

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Jan 9, 2025

Summary

Updated default cloud plan text to Teams Cloud and Teams
Should be updated later based on the plan type

Screenshots

Before
Screenshot 2025-01-10 at 00 12 08

After
Screenshot 2025-01-10 at 00 10 22


Important

Update default cloud plan text in billing UI from 'Enterprise Cloud' to 'Teams Cloud' and 'Enterprise' to 'Teams'.

  • Localization:
    • Add teams_cloud and teams keys to billings.json.
  • UI Update:
    • Change plan display text in BillingContainer.tsx from enterprise_cloud to teams_cloud and enterprise to teams based on isCloudUserVal.

This description was created by Ellipsis for 83d8f71. It will automatically update as commits are pushed.

@makeavish makeavish requested a review from YounixM as a code owner January 9, 2025 18:42
@github-actions github-actions bot added the chore label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 83d8f71 in 29 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/public/locales/en/billings.json:6
  • Draft comment:
    The translation keys teams_cloud and teams are added but not used in the code. Ensure they are necessary or remove them to avoid unused code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The translation keys 'teams_cloud' and 'teams' are added in the JSON file but not used in the code. This could lead to confusion or unused code.
2. frontend/src/container/BillingContainer/BillingContainer.tsx:433
  • Draft comment:
    The use of t('teams_cloud') and t('teams') is consistent with the added translation keys. Ensure these keys exist in the translation files.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code uses t('teams_cloud') and t('teams') for translation, which matches the added keys in the JSON file. This is correct and consistent with the PR description.
3. frontend/src/container/BillingContainer/BillingContainer.tsx:432
  • Draft comment:
    Avoid using inline styles. Consider using CSS classes or styled components instead. This applies to other inline styles in this file as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.
4. frontend/src/container/BillingContainer/BillingContainer.tsx:433
  • Draft comment:
    Use design tokens or predefined color constants instead of hardcoding color values. This applies to other hardcoded colors in this file as well.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_Kr7ckOhIl9rgXhPD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25 vikrantgupta25 enabled auto-merge (squash) January 9, 2025 18:57
@vikrantgupta25 vikrantgupta25 merged commit 68ee677 into main Jan 9, 2025
16 of 19 checks passed
@vikrantgupta25 vikrantgupta25 deleted the chore/update-cloud-plan-default-text branch January 9, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants