Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDI monitoring quickstart - 2nd try #11

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

tborcin
Copy link

@tborcin tborcin commented Jan 19, 2017

Opening second pull request and hopefully this one contains all work done on CDI monitoring quickstart.

Copy link
Contributor

@livthomas livthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than before. :-) But some changes need to be made.

@@ -1,230 +1,233 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem as in SilverWare repository. This file has been reformatted using 2-space indents instead of 3 spaces defined in our code style and so it is hard to see the changes.

@@ -0,0 +1,63 @@
package io.silverware.demos.quickstarts.cdi.monitoring;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

@@ -0,0 +1,49 @@
package io.silverware.demos.quickstarts.cdi.monitoring;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

@@ -0,0 +1,51 @@
package io.silverware.demos.quickstarts.cdi.monitoring;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

@livthomas livthomas mentioned this pull request Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants