Update tolerances for cep tests and fix continuous integration issues for Ubuntu #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 62.90% 62.91% +0.01%
==========================================
Files 105 105
Lines 27214 27214
==========================================
+ Hits 17119 17122 +3
+ Misses 10095 10092 -3 ☔ View full report in Codecov by Sentry. |
MatteoSalvador
changed the title
|
Nicely done! I'll merge this now, but maybe we can add brief instructions on using the containers in @dcodoni's future PR? |
mrp089
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tightens linear and nonlinear solver tolerances for all cep tests.
Furthermore, it adds a first version of docker containers for
Ubuntu 20.04andUbuntu 22.04endowed withVTK 9.3.0, which will ensure stability and updated libraries forsvFSIplus(see #211). This PR will complement the work of @dcodoni, where all the linked libraries (includingTrilinosandPETSc) will be updated to the latest version to guarantee that the best performance and the most updated features are always available withinsvFSIplus.The docker images, together with the corresponding instructions to generate/install them, are publicly available for Ubuntu 20.04 and Ubuntu 22.04.
Code of Conduct & Contributing Guidelines