Improve handling of SVG image attachments and WYSIWYG attachment previews #7721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sesquipedalian
changed the title
live627
reviewed
Mar 26, 2023
live627
reviewed
Mar 26, 2023
Sesquipedalian
force-pushed
the
svg_attachments
branch
from
1e681fd
to
97d7b7a
Compare
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
svg_attachments
branch
2 times, most recently
from
fa0b7a2
to
023794c
Compare
|
Ready for another review, @live627. |
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
svg_attachments
branch
from
023794c
to
860dab6
Compare
Signed-off-by: Jon Stovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7719 by showing SVG attachments as images.
The fiddliest part was handling thumbnails. SVG images don't need thumbnails for obvious reasons, but SMF assumes that images do need them. So I had to add some special handling for SVGs to tell SMF that the SVG image is its own thumbnail, and then slightly tweak the JavaScript used to expand thumbnails when the user clicks on them.
Fixes #7720 by showing original images for embedded attachments in WYSIWYG editor.
The basic task of switching from thumbnails to original images merely required changing
thumbtoimageon the relevant line in jquery.sceditor.smf.js. However, to prevent the download counter from incrementing unexpectedly, I also had to resurrect thepreviewURL parameter in ShowAttachment.php as a way to tell SMF that this shouldn't count as a download.