Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows "Last Edit" info (if applicable) when editing a post #7722

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

Sesquipedalian
Copy link
Member

@Sesquipedalian Sesquipedalian commented Mar 26, 2023

The logic for setting $context['last_modified_text'] was broken. This fixes it, and also simplifies how we handle and display that information in the posting fields on the editor page.

@jdarwood007 jdarwood007 added this to the 2.1.5 milestone Mar 26, 2023
@Sesquipedalian
Copy link
Member Author

@jdarwood007: I'm not 100% sure, but I get the impression that @sbulen actually plans to put this into 2.1.4 rather than 2.1.5, since it is connected with #7676. I could be entirely wrong, of course.

@jdarwood007
Copy link
Member

Sounded like it was an existing bug, not one introduced by that PR?

@Sesquipedalian
Copy link
Member Author

The bug itself already existed, yes. But the changes needed in order to fix it also affect some of the new code introduced in #7676. Because of that, it wouldn't make a whole lot of sense to leave this out, at least to my mind. But it's up to you folks to decide, of course.

@jdarwood007
Copy link
Member

Ok. I will leave it up for @sbulen then to decide. I interrupted it as a existing bug so we can leave it out while we work to finalize 2.1.4

@DiegoAndresCortes
Copy link
Member

Why is it using $context['last_modified_reason'] in the value, wouldn't it be censored?

@Sesquipedalian
Copy link
Member Author

Why is it using $context['last_modified_reason'] in the value, wouldn't it be censored?

Excellent catch! It would indeed. I have fixed that now.

@Sesquipedalian Sesquipedalian merged commit 3ec6008 into SimpleMachines:release-2.1 Sep 24, 2023
8 checks passed
@Sesquipedalian Sesquipedalian deleted the last_edit branch September 25, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants